HCIDOCS-760: Follow-up to HCIDOCS-729 #96159
Conversation
|
@tshwartz: This pull request references HCIDOCS-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/XS
|
@tshwartz: This pull request references HCIDOCS-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tshwartz: This pull request references HCIDOCS-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tshwartz: This pull request references HCIDOCS-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tshwartz: This pull request references HCIDOCS-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Wed Jul 16 16:46:25 - Prow CI generated the docs preview: |
|
@tshwartz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
skopacz1
added
merge-review-in-progress
There was a problem hiding this comment.
Merge review LGTM. I would normally say this still needs peer review despite it being a follow up on merge review comments, but the change is small enough, I am willing to say I peer reviewed this as well, and in either case peer review is about to go away in a few days.
skopacz1
added
the
peer-review-done
|
/cherrypick enterprise-4.16 |
|
@skopacz1: new pull request created: #96259 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96261 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96263 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96264 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96265 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
skopacz1
removed
merge-review-in-progress
Version(s):
4.16, 4.17, 4.18, 4.19, 4.20, main
Issue:
https://issues.redhat.com/browse/HCIDOCS-760
Link to docs preview:
QE review:
Additional information:
Applied peer and merge reviewer comments here: #96070
Created a separate Jira so that I could apply to all relevant OCP versions and not just 4.16.